Code review comment for lp:~bjornt/landscape-client/apt-channel-api

On Wed, Sep 28, 2011 at 12:56:28PM -0000, Alberto Donato wrote:
> Review: Approve
>
> Nice, +1!
>
> #1:
> + sources_file_path = sources_dir + "/landscape-internal-facade.list"
>
> #2:
> + with open(path + "/Packages", "a") as packages:
>
> these should use os.path.join()

Sure.

> #3:
> + with open(list_filename, "r") as sources:
> + sources_contents = sources.read()
>
> you can use read_file() from landscape.lib.fs here (there are multiple
> tests with similar code)

Sure. I added append_file() as well, and replaced the with statements
that appended contents to files.

--
Björn Tillenius | https://launchpad.net/~bjornt