Code review comment for lp:~bjornt/landscape-client/apt-channel-api

Revision history for this message
Alberto Donato (ack) wrote :

Nice, +1!

#1:
+ sources_file_path = sources_dir + "/landscape-internal-facade.list"

#2:
+ with open(path + "/Packages", "a") as packages:

these should use os.path.join()

#3:
+ with open(list_filename, "r") as sources:
+ sources_contents = sources.read()

you can use read_file() from landscape.lib.fs here (there are multiple tests with similar code)

review: Approve

« Back to merge proposal