Code review comment for lp:~bitzesmichail/compiz/splash-gles

Revision history for this message
Michail Bitzes (bitzesmichail) wrote :

 > 1. During testing I found that the option Main->"Show on first start" does not
> work correctly. If disabled Splash will still show on Compiz start, no matter
> if first or second. Could you try to fix that also, when you are on it ?

I can look at it tomorrow.

> 2. We introduced some minor indentation problems in the Firepaint GL|ES merge
> and optimized the if statements in Showmouse, do you want to propose a MP with
> the Firepaint fixes (indentation and better readability for the if
> statements), or should I do it ?

You can do it.

> 3. Unfortunately the Wizard is still a bit unstable when you start to
> customize the particles, while working stable with the defaults, did you make
> progress/are you still working on it and the GL|ES version ?

Unstable = slow or crash?
I made a branch with the GLES port, I haven't proposed it yet.

« Back to merge proposal