Code review comment for lp:~bitshifternz/unity/fix-for-bug-769781

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Approve, however being pedantic here, line 18 has weird indentation, you might want to fix that :)

Also, just for super-super-correctness, you might want to do the check against the window size minus the decorations geometry. So for that you'd have (screen_width - window->border ().left () - window->border ().right () > size_hints.max_width) ... if that makes any sense.

review: Approve

« Back to merge proposal