Code review comment for ~binli/checkbox-support/+git/checkbox-support:dmic-support

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Thanks a lot for the fix, this pactl parser is a pain to maintain across releases.

Could you attach to the test collection the `pactl list` output here:

https://git.launchpad.net/checkbox-support/tree/checkbox_support/parsers/tests/pactl_data

and write a unit test for this dmic:

https://git.launchpad.net/checkbox-support/tree/checkbox_support/parsers/tests/test_pactl.py

setup.py test should also tell you if the proposed fix does not add a regression to the older behaviors.

review: Needs Fixing

« Back to merge proposal