Merge bileto:drop-obsolete-series into bileto:master

Proposed by Steve Langasek
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: e549646bd9be50ae012272948436b5c70cf7768b
Merged at revision: e549646bd9be50ae012272948436b5c70cf7768b
Proposed branch: bileto:drop-obsolete-series
Merge into: bileto:master
Diff against target: 47 lines (+2/-9)
2 files modified
bileto/v2.py (+1/-7)
tests/test_v2.py (+1/-2)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+357863@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is good, but needs some additional changes. Right now the tests are failing as there are places where SERIES is still referenced.

But I'll fix that.

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/bileto/v2.py b/bileto/v2.py
index b6a3c3c..a6cc3e7 100644
--- a/bileto/v2.py
+++ b/bileto/v2.py
@@ -34,12 +34,6 @@ FAILURES = ('can\'t', 'caught', 'error', 'exception',
34EXPAND = {'search'}34EXPAND = {'search'}
35CONTRACT = EXPAND | {'comments', 'merge_proposals'}35CONTRACT = EXPAND | {'comments', 'merge_proposals'}
36SLASH = '/'36SLASH = '/'
37SERIES = [
38 'zesty-overlay, xenial-overlay',
39 'zesty, xenial-overlay',
40 'zesty, yakkety',
41 'zesty, yakkety, xenial',
42]
4337
4438
45def assert_json():39def assert_json():
@@ -195,7 +189,7 @@ def v2_metadata_get():
195 lander_signoff=signoff,189 lander_signoff=signoff,
196 qa_signoff=['Ready'] + signoff,190 qa_signoff=['Ready'] + signoff,
197 distribution=['ubuntu'],191 distribution=['ubuntu'],
198 series=SERIES + series,192 series=series,
199 dest=['', '{}/ubuntu/stable-phone-overlay'.format(team)],193 dest=['', '{}/ubuntu/stable-phone-overlay'.format(team)],
200 status=(194 status=(
201 'New',195 'New',
diff --git a/tests/test_v2.py b/tests/test_v2.py
index 412c844..0a56d44 100644
--- a/tests/test_v2.py
+++ b/tests/test_v2.py
@@ -12,7 +12,6 @@ from mock import patch
1212
13from bileto.models import Ticket, Comment13from bileto.models import Ticket, Comment
14from bileto.app import db14from bileto.app import db
15from bileto.v2 import SERIES
1615
17from tests.tests import BiletoTestCase16from tests.tests import BiletoTestCase
1817
@@ -631,7 +630,7 @@ class V2TestCase(BiletoTestCase):
631 distribution=['ubuntu'],630 distribution=['ubuntu'],
632 lander_signoff=['', 'Approved', 'Failed'],631 lander_signoff=['', 'Approved', 'Failed'],
633 qa_signoff=['Ready', '', 'Approved', 'Failed'],632 qa_signoff=['Ready', '', 'Approved', 'Failed'],
634 series=SERIES + ['alpha', 'beta'],633 series=['alpha', 'beta'],
635 status=['New', 'Landed', 'Abandoned']),634 status=['New', 'Landed', 'Abandoned']),
636 ppa_team='team-not-set',635 ppa_team='team-not-set',
637 devel='alpha',636 devel='alpha',

Subscribers

People subscribed via source and target branches

to all changes: