Code review comment for lp:~bilalakhtar/unity/waiting-to-install-tooltip-925014

Revision history for this message
Tim Penhey (thumper) wrote :

Why are you including <string.h> in launcher/SoftwareCenterLauncherIcon.cpp?

In launcher/SoftwareCenterLauncherIcon.h, include <string> (not
<string.h>) and put it before <UnityCore/GLibDBusProxy.h>.

Standard includes first, then other libraries, then locals.

review: Needs Fixing

« Back to merge proposal