Code review comment for lp:~bigon/ubuntu-sso-client/gnome3-gnome-keyring

Revision history for this message
dobey (dobey) wrote :

This is a separate issue from the CreateItem bug. Your patch also breaks compatibility with gnome-keyring 2.x, which we need to maintain. And you will need to sign the Canonical Contributor Agreement as detailed on http://www.canonical.com/contributors .

Thanks.

review: Needs Fixing

« Back to merge proposal