Merge lp:~bigkevmcd/offspring/fix-bug-983465 into lp:offspring

Proposed by Kevin McDermott
Status: Merged
Merged at revision: 181
Proposed branch: lp:~bigkevmcd/offspring/fix-bug-983465
Merge into: lp:offspring
Diff against target: 43 lines (+10/-3)
2 files modified
lib/offspring/web/queuemanager/tests/test_views.py (+8/-1)
lib/offspring/web/templates/queuemanager/builds.html (+2/-2)
To merge this branch: bzr merge lp:~bigkevmcd/offspring/fix-bug-983465
Reviewer Review Type Date Requested Status
Timothy R. Chavez Approve
Review via email: mp+192475@code.launchpad.net

Description of the change

This is a trival test and fix for this bug, am surprised it's gone so long without a fix...

To post a comment you must log in.
Revision history for this message
Timothy R. Chavez (timrchavez) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/offspring/web/queuemanager/tests/test_views.py'
--- lib/offspring/web/queuemanager/tests/test_views.py 2013-10-10 15:23:03 +0000
+++ lib/offspring/web/queuemanager/tests/test_views.py 2013-10-24 09:44:51 +0000
@@ -392,7 +392,11 @@
392 def setUp(self):392 def setUp(self):
393 self.user = factory.make_user()393 self.user = factory.make_user()
394 self.project = factory.make_project()394 self.project = factory.make_project()
395 self.build = factory.make_build_result(project=self.project)395 started_at = datetime.utcnow() - timedelta(hours=2)
396 self.build = factory.make_build_result(
397 project=self.project,
398 finished_at=started_at + timedelta(minutes=30),
399 started_at=started_at)
396 self.view_url = reverse('offspring.web.queuemanager.views.builds')400 self.view_url = reverse('offspring.web.queuemanager.views.builds')
397401
398 def test_builds_view(self):402 def test_builds_view(self):
@@ -403,6 +407,9 @@
403 self.assertContains(407 self.assertContains(
404 response, self.build.name, status_code=200,408 response, self.build.name, status_code=200,
405 msg_prefix=response.content)409 msg_prefix=response.content)
410 fmt = "%b %d %Y %H:%M:%S"
411 self.assertContains(response, self.build.started_at.strftime(fmt))
412 self.assertContains(response, self.build.finished_at.strftime(fmt))
406413
407414
408class LaunchpadProjectViewsTests(TestCase):415class LaunchpadProjectViewsTests(TestCase):
409416
=== modified file 'lib/offspring/web/templates/queuemanager/builds.html'
--- lib/offspring/web/templates/queuemanager/builds.html 2013-07-04 19:45:29 +0000
+++ lib/offspring/web/templates/queuemanager/builds.html 2013-10-24 09:44:51 +0000
@@ -43,10 +43,10 @@
43 {% endif %}43 {% endif %}
44 </td>44 </td>
45 <td>45 <td>
46 {{ build_result.started_at|default:""|date:"M d Y H:m:s" }}46 {{ build_result.started_at|default:""|date:"M d Y H:i:s" }}
47 </td>47 </td>
48 <td>48 <td>
49 {{ build_result.finished_at|default:""|date:"M d Y H:m:s" }}49 {{ build_result.finished_at|default:""|date:"M d Y H:i:s" }}
50 </td>50 </td>
51 <td>51 <td>
52 {% if build_result.requestor %}52 {% if build_result.requestor %}

Subscribers

People subscribed via source and target branches