Merge lp:~bigkevmcd/offspring/fix-bug-983465 into lp:offspring

Proposed by Kevin McDermott
Status: Merged
Merged at revision: 181
Proposed branch: lp:~bigkevmcd/offspring/fix-bug-983465
Merge into: lp:offspring
Diff against target: 43 lines (+10/-3)
2 files modified
lib/offspring/web/queuemanager/tests/test_views.py (+8/-1)
lib/offspring/web/templates/queuemanager/builds.html (+2/-2)
To merge this branch: bzr merge lp:~bigkevmcd/offspring/fix-bug-983465
Reviewer Review Type Date Requested Status
Timothy R. Chavez Approve
Review via email: mp+192475@code.launchpad.net

Description of the change

This is a trival test and fix for this bug, am surprised it's gone so long without a fix...

To post a comment you must log in.
Revision history for this message
Timothy R. Chavez (timrchavez) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/offspring/web/queuemanager/tests/test_views.py'
2--- lib/offspring/web/queuemanager/tests/test_views.py 2013-10-10 15:23:03 +0000
3+++ lib/offspring/web/queuemanager/tests/test_views.py 2013-10-24 09:44:51 +0000
4@@ -392,7 +392,11 @@
5 def setUp(self):
6 self.user = factory.make_user()
7 self.project = factory.make_project()
8- self.build = factory.make_build_result(project=self.project)
9+ started_at = datetime.utcnow() - timedelta(hours=2)
10+ self.build = factory.make_build_result(
11+ project=self.project,
12+ finished_at=started_at + timedelta(minutes=30),
13+ started_at=started_at)
14 self.view_url = reverse('offspring.web.queuemanager.views.builds')
15
16 def test_builds_view(self):
17@@ -403,6 +407,9 @@
18 self.assertContains(
19 response, self.build.name, status_code=200,
20 msg_prefix=response.content)
21+ fmt = "%b %d %Y %H:%M:%S"
22+ self.assertContains(response, self.build.started_at.strftime(fmt))
23+ self.assertContains(response, self.build.finished_at.strftime(fmt))
24
25
26 class LaunchpadProjectViewsTests(TestCase):
27
28=== modified file 'lib/offspring/web/templates/queuemanager/builds.html'
29--- lib/offspring/web/templates/queuemanager/builds.html 2013-07-04 19:45:29 +0000
30+++ lib/offspring/web/templates/queuemanager/builds.html 2013-10-24 09:44:51 +0000
31@@ -43,10 +43,10 @@
32 {% endif %}
33 </td>
34 <td>
35- {{ build_result.started_at|default:""|date:"M d Y H:m:s" }}
36+ {{ build_result.started_at|default:""|date:"M d Y H:i:s" }}
37 </td>
38 <td>
39- {{ build_result.finished_at|default:""|date:"M d Y H:m:s" }}
40+ {{ build_result.finished_at|default:""|date:"M d Y H:i:s" }}
41 </td>
42 <td>
43 {% if build_result.requestor %}

Subscribers

People subscribed via source and target branches