Merge lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk into lp:charms/trusty/apache-hadoop-client

Proposed by Cory Johns
Status: Merged
Merged at revision: 102
Proposed branch: lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk
Merge into: lp:charms/trusty/apache-hadoop-client
Diff against target: 103 lines (+4/-43)
4 files modified
README.md (+1/-1)
tests/00-setup (+0/-8)
tests/01-basic-deployment.py (+0/-34)
tests/tests.yaml (+3/-0)
To merge this branch: bzr merge lp:~bigdata-dev/charms/trusty/apache-hadoop-client/trunk
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
Review via email: mp+273434@code.launchpad.net

Description of the change

Remove trivial test in favor of bundle tests.

To post a comment you must log in.
102. By Cory Johns

Re-added trivial test

103. By Cory Johns

Update mailing list

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

LGTM, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'README.md'
--- README.md 2015-08-24 23:19:00 +0000
+++ README.md 2015-10-06 18:07:13 +0000
@@ -25,7 +25,7 @@
2525
26## Contact Information26## Contact Information
2727
28- <bigdata-dev@lists.launchpad.net>28- <bigdata@lists.ubuntu.com>
2929
3030
31## Hadoop31## Hadoop
3232
=== added directory 'tests'
=== removed directory 'tests'
=== removed file 'tests/00-setup'
--- tests/00-setup 2015-02-16 22:20:57 +0000
+++ tests/00-setup 1970-01-01 00:00:00 +0000
@@ -1,8 +0,0 @@
1#!/bin/bash
2
3if ! dpkg -s amulet &> /dev/null; then
4 echo Installing Amulet...
5 sudo add-apt-repository -y ppa:juju/stable
6 sudo apt-get update
7 sudo apt-get -y install amulet
8fi
90
=== added file 'tests/01-basic-deployment.py'
--- tests/01-basic-deployment.py 1970-01-01 00:00:00 +0000
+++ tests/01-basic-deployment.py 2015-10-06 18:07:13 +0000
@@ -0,0 +1,24 @@
1#!/usr/bin/env python3
2
3import unittest
4import amulet
5
6
7class TestDeploy(unittest.TestCase):
8 """
9 Trivial deployment test for Apache Hadoop Cliennt.
10
11 This charm cannot do anything useful by itself, so integration testing
12 is done in the bundle.
13 """
14
15 def test_deploy(self):
16 self.d = amulet.Deployment(series='trusty')
17 self.d.add('client', 'apache-hadoop-client')
18 self.d.setup(timeout=900)
19 self.d.sentry.wait(timeout=1800)
20 self.unit = self.d.sentry['client'][0]
21
22
23if __name__ == '__main__':
24 unittest.main()
025
=== removed file 'tests/01-basic-deployment.py'
--- tests/01-basic-deployment.py 2015-09-15 17:13:14 +0000
+++ tests/01-basic-deployment.py 1970-01-01 00:00:00 +0000
@@ -1,34 +0,0 @@
1#!/usr/bin/env python3
2
3import unittest
4import amulet
5
6
7class TestDeploy(unittest.TestCase):
8 """
9 Basic deployment test for Apache Hadoop Client.
10
11 This charm cannot do anything useful by itself, so integration testing
12 is done in the bundle.
13 """
14
15 @classmethod
16 def setUpClass(cls):
17 cls.d = amulet.Deployment(series='trusty')
18 cls.d.add('apache-hadoop-client')
19 cls.d.setup(timeout=900)
20 cls.d.sentry.wait(timeout=1800)
21 cls.unit = cls.d.sentry.unit['apache-hadoop-client/0']
22
23 def test_deploy(self):
24 output, retcode = self.unit.run("pgrep -a java")
25 assert 'ResourceManager' not in output, "ResourceManager should not be started"
26 assert 'JobHistoryServer' not in output, "JobHistoryServer should not be started"
27 assert 'NodeManager' not in output, "NodeManager should not be started"
28 assert 'NameNode' not in output, "NameNode should not be started"
29 assert 'SecondaryNameNode' not in output, "SecondaryNameNode should not be started"
30 assert 'DataNode' not in output, "DataServer should not be started"
31
32
33if __name__ == '__main__':
34 unittest.main()
350
=== added file 'tests/tests.yaml'
--- tests/tests.yaml 1970-01-01 00:00:00 +0000
+++ tests/tests.yaml 2015-10-06 18:07:13 +0000
@@ -0,0 +1,3 @@
1reset: false
2packages:
3 - amulet

Subscribers

People subscribed via source and target branches