Code review comment for lp:~bidossessi-sodonon/synapse-project/mpc-plugin

Revision history for this message
Bidossessi Sodonon (bidossessi-sodonon) wrote :

> A few notes:
>
> - please revert the changes to hybrid-search-plugin
> - line 210-217 and others - why do you catch the error, if you only re-throw
> it?
>
> Other than that it looks ok...
Well, I kept catching until vala stopped giving me unhandled error messages. They were kind of scary. But I admint there's no real need to do that.

I believe that with 449, this plugin is ready.

« Back to merge proposal