Merge lp:~bialix/trac-bzr/0.3-bug-675014 into lp:trac-bzr/0.3

Proposed by Alexander Belchenko
Status: Needs review
Proposed branch: lp:~bialix/trac-bzr/0.3-bug-675014
Merge into: lp:trac-bzr/0.3
Diff against target: 20 lines (+2/-1)
1 file modified
tracbzr/backend.py (+2/-1)
To merge this branch: bzr merge lp:~bialix/trac-bzr/0.3-bug-675014
Reviewer Review Type Date Requested Status
Richard Wilbur Approve
Review via email: mp+133430@code.launchpad.net

Description of the change

This is a small change to fix Bug #675014 in 0.3 branch. I'm still using 0.3.3 so this change helps me a lot.

To post a comment you must log in.
Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Alexander are you still using 0.3.3? Do you think there is a group of other who are still using 0.3.3?

This looks like a good change.
+1

review: Approve

Unmerged revisions

119. By Alexander Belchenko

Simple fix for Bug #675014: InvalidURL: URL was not a plain ASCII url: pass to bzrlib urlencoded path, not plain unicode path.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tracbzr/backend.py'
2--- tracbzr/backend.py 2010-04-10 17:56:06 +0000
3+++ tracbzr/backend.py 2012-11-08 09:37:26 +0000
4@@ -68,6 +68,7 @@
5 osutils,
6 revision,
7 transport,
8+ urlutils,
9 )
10 import bzrlib.api
11 from bzrlib.revision import (
12@@ -1337,7 +1338,7 @@
13
14
15 def containing_branch(transport, path):
16- child_transport = transport.clone(path)
17+ child_transport = transport.clone(urlutils.escape(path))
18 my_bzrdir, relpath = \
19 bzrdir.BzrDir.open_containing_from_transport(child_transport)
20 return my_bzrdir.open_branch(), relpath

Subscribers

People subscribed via source and target branches