Code review comment for lp:~bialix/bzr/relpath-docstring

Revision history for this message
Andrew Bennetts (spiv) wrote :

The meaning of "false negative result" wasn't clear to me. I had to experiment to be sure. How about saying "NOTE: `base` should not have a trailing slash otherwise you'll get PathNotChild exceptions regardless of `path`."?

Even better would be to fix that behaviour: that sounds very much like a bug to me. But in the meantime a clearer docstring is certainly an improvement.

review: Needs Fixing

« Back to merge proposal