Code review comment for lp:~bialix/bzr/no-single-quote-on-win32

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

> I've showed this session as example of cmd.exe behavior and maybe as possible source for extending test suite. I'm still trying to figure out how your new command-line parsing may impact on qsubprocess and bencoded command-line.

If qbzr wraps everything in "" as most programs do, then I think
everything will be ok. It may need to do:

args = [" + arg.replace('"', '\\"') + " for arg in args]

Which generally wraps any argument in "" and then escapes any embedded
quotes.

With that syntax, bzr should be the same as the standard
CommandLineToArgv parser. (caveat bugs)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAkr2Eo8ACgkQJdeBCYSNAANjXgCgiu3cHX0sblh0hENKO0u/nzm6
Bo0AkwVm8qdMNqfU8BuMLN/Q5CcMDj8=
=9Dql
-----END PGP SIGNATURE-----

« Back to merge proposal