Code review comment for lp:~bialix/bzr/no-single-quote-on-win32

Revision history for this message
Robert Collins (lifeless) wrote :

On Sat, 2009-11-07 at 16:30 +0000, Gordon Tyler wrote:
> Review: Approve
> Handling of quoted commandline arguments is the responsibility of the shell.

So is glob expansion, but we do that in bzr on windows. Why is glob
expansion something bzr should do, but not quoting?

John - does
c:\foo\> bzr commit -m "foo'bar"
work at the moment ? If not, we should fix that - on unix we'd want
"foo'bar" not "foobar" as the resulting string.

For now, I'm abstaining, as I don't use windows either. I *do* think it
would be very nice to be able to have our docs be the same for win32 and
unix as far as handling paths with spaces.

-Rob

« Back to merge proposal