Robert Collins wrote:
> On Mon, 2009-07-06 at 13:05 +0000, Alexander Belchenko wrote:
> > Alexander Belchenko has proposed merging lp:~bialix/bzr/lp-bzr.exe into lp:bzr.
> >
> > Requested reviews:
> > Jonathan Lange (jml)
> > bzr-core (bzr-core)
> >
> > Better support for bzr.exe: `import webbrowser` should not be lazy.
>
> This penalises every execution of bzr.
Actually, it doesn't; it's only imported inside cmd_launchpad_open.run
immediately before it is used. So it's still lazy, it's just not using
lazy_import. So to be pedantic, it improves every execution of bzr, because it
creates one less lazy-proxy object ;)
It would be nice if whatever builds bzr.exe worked just fine with lazy_import,
but this patch seems ok to me.
Robert Collins wrote:
> On Mon, 2009-07-06 at 13:05 +0000, Alexander Belchenko wrote:
> > Alexander Belchenko has proposed merging lp:~bialix/bzr/lp-bzr.exe into lp:bzr.
> >
> > Requested reviews:
> > Jonathan Lange (jml)
> > bzr-core (bzr-core)
> >
> > Better support for bzr.exe: `import webbrowser` should not be lazy.
>
> This penalises every execution of bzr.
Actually, it doesn't; it's only imported inside cmd_launchpad_ open.run
immediately before it is used. So it's still lazy, it's just not using
lazy_import. So to be pedantic, it improves every execution of bzr, because it
creates one less lazy-proxy object ;)
It would be nice if whatever builds bzr.exe worked just fine with lazy_import,
but this patch seems ok to me.
review approve
-Andrew.