Code review comment for lp:~bialix/bzr/commit-rev-id

Revision history for this message
Martin Pool (mbp) wrote :

I think some of our use of methodobjects is questionable, as is putting variables onto objects when they're really not naturally object state but something more like local variables.

However, given that this code is already done this way, John's patch of 2009-11-17 is better.

If it's possible to remove self.rev_id altogether that could be good, though that would constitute an API break.

review: Needs Fixing

« Back to merge proposal