Code review comment for lp:~bialix/bzr/2.4-bug-967060

Revision history for this message
Alexander Belchenko (bialix) wrote :

Martin Packman пишет:
> How about using properties returning 0 instead? This isn't a class designed for minimising memory usage, but as these values serve no purpose there seems no point storing them.

Well, thinking about it more I'd like to avoid properties because they
mean more code for no real benefit. To avoid duplication in explicit
initialization of those 4 members to zero, I'd prefer move them into
constructor (__init__ method). There is no constructor today, but we can
add it.

--
All the dude wanted was his rug back

« Back to merge proposal