Code review comment for lp:~bialix/bzr-windows-installers/changelog_plugin

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/4/2011 11:19 AM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging lp:~bialix/bzr-windows-installers/changelog_plugin into lp:bzr-windows-installers.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~bialix/bzr-windows-installers/changelog_plugin/+merge/66760
>
> Add built-in changelog_merge plugin to standalone installer.

Also Alexander, you still have all of the 'bzr' tags in your branch. You
can run:

 cd bzr-windows-installers
 for t in `cat deleted_tags.txt`; do bzr tag --delete $t; done

I'm not sure how else for you to do it. (You can copy the
.bzr/branch/tags file from Launchpad and overwrite your own, I guess.)

I noticed because bzr>2.3 will copy all the revisions for all the tags,
which means that committing/pushing to a bzr-windows-installers branch
will copy up the whole history of bzr if you haven't deleted the extra tags.

It is a little bit cumbersome, I agree. The other option is to delete
your local branch, and start from scratch from
'lp:bzr-windows-installers'. I've verified that it doesn't have the
extra tags.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4S5VAACgkQJdeBCYSNAAOnsQCgzIvS2jo1GX83MktvsIAAFbxz
WO0AniDIkLTGvAnMJ9MGMxwqEq15Pt80
=qZAi
-----END PGP SIGNATURE-----

« Back to merge proposal