Code review comment for ~bhill/epics-base:pvAccess-envDefs.h

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

pvAccessCPP will now use these parameters.

However, I'm having second (third?) thoughts about the idea of having a second or third set of default values for these parameters, which are sometimes are used, and sometimes ignored.

Probably the most confusing is EPICS_PVAS_PROVIDER_NAMES. A default value of "local" will actually prevent QSRV from starting! ("local" is the name used by pvDatabaseCPP) The actual default is "<all>", which selects all registered server-type ChannelProviders.

I'm tempted to say that it would be better to defer to the "pvasr" iocsh function, which can print the configuration actually being used by the running server (in IOCs).

That said, the set of parameters which I think should be advertised are:

EPICS_PVA_ADDR_LIST
EPICS_PVA_AUTO_ADDR_LIST
EPICS_PVA_BROADCAST_PORT
EPICS_PVA_SERVER_PORT
EPICS_PVAS_BEACON_ADDR_LIST
EPICS_PVAS_SERVER_PORT
EPICS_PVAS_INTF_ADDR_LIST
EPICS_PVAS_BROADCAST_PORT

« Back to merge proposal