Code review comment for ~bhill/epics-base:EPICS-and-CA-version-from-CA-tools

Revision history for this message
Bruce Hill (bhill) wrote :

> There is no reason to
> change all of the includes (back) from brackets '<>' to quotes '""'.

I've backed out these changes but am not clear why you object.
As a general rule, all EPICS headers should be included with quotes to
make sure object files get rebuilt when needed. I'm often switching
IOC's and modules to build w/ different base releases, and if I'm working
on bugs or features in base, files should get recompiled if any of the
EPICS headers change.

There is little advantage to using brackets for your include statements.
At best you get a slight increase in compile time, but we could have
more impact by working on our makefiles to reduce all the unnecessary
implicit rules and prerequisites that cause make to look for non-existent files.

I'm inclined to submit the #include line changes as their own change request.
Any objections?

« Back to merge proposal