Merge lp:~bfiller/unity-2d/metacity-cycle-workspace-switcher into lp:~unity-2d-team/unity-2d/metacity

Proposed by Bill Filler
Status: Merged
Approved by: Aurélien Gâteau
Approved revision: 102
Merged at revision: 102
Proposed branch: lp:~bfiller/unity-2d/metacity-cycle-workspace-switcher
Merge into: lp:~unity-2d-team/unity-2d/metacity
Diff against target: 47 lines (+25/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/17-workspace-switcher-cycle.patch (+15/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~bfiller/unity-2d/metacity-cycle-workspace-switcher
Reviewer Review Type Date Requested Status
Aurélien Gâteau (community) Approve
Review via email: mp+48997@code.launchpad.net

Description of the change

This change allows the workspace switcher to cycle from last to first workspace when using the right arrow key when current workspace is the last workspace. Similarly, if current workspace is the first workspace and the left arrow is pressed in the workspace switcher the workspace is switched to last workspace. This is similar to how most compiz workspace switchers (i.e. cube) work.

To post a comment you must log in.
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Works fine, but branch needs to be updated as Metacity has been updated to 2.30.3 in Natty (Patch applies without problem on the new version)

review: Needs Fixing
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Since it applies just fine against Maverick, let's approve it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-02-05 13:20:50 +0000
+++ debian/changelog 2011-02-08 22:38:15 +0000
@@ -1,3 +1,12 @@
1metacity (1:2.30.2-0ubuntu1upicek6) maverick; urgency=low
2
3 * debian/patches/17-workspace-switcher-cycle.patch: added patch
4 to cause workspace switcher to cycle from last workspace to
5 first workspace and vice versa when using arrow keys. This
6 allows functionality similar to workspace switcher in compiz
7
8 -- Bill Filler <bill.filler@canonical.com> Tue, 08 Feb 2011 17:27:04 -0500
9
1metacity (1:2.30.2-0ubuntu1upicek5) maverick; urgency=low10metacity (1:2.30.2-0ubuntu1upicek5) maverick; urgency=low
211
3 * Enable the capture before unmap option by default12 * Enable the capture before unmap option by default
413
=== added file 'debian/patches/17-workspace-switcher-cycle.patch'
--- debian/patches/17-workspace-switcher-cycle.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/17-workspace-switcher-cycle.patch 2011-02-08 22:38:15 +0000
@@ -0,0 +1,15 @@
1diff -Nur -x '*.orig' -x '*~' metacity-2.30.2//src/core/workspace.c metacity-2.30.2.new//src/core/workspace.c
2--- metacity-2.30.2//src/core/workspace.c 2011-02-08 17:17:36.000000000 -0500
3+++ metacity-2.30.2.new//src/core/workspace.c 2011-02-08 17:23:00.628654844 -0500
4@@ -840,9 +840,9 @@
5 }
6
7 if (layout.current_col < 0)
8- layout.current_col = 0;
9+ layout.current_col = num_workspaces - 1;
10 if (layout.current_col >= layout.cols)
11- layout.current_col = layout.cols - 1;
12+ layout.current_col = 0;
13 if (layout.current_row < 0)
14 layout.current_row = 0;
15 if (layout.current_row >= layout.rows)
016
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-02-02 18:34:40 +0000
+++ debian/patches/series 2011-02-08 22:38:15 +0000
@@ -11,5 +11,6 @@
1114_wrong_colormap.patch1114_wrong_colormap.patch
1215_show_maximized_titlebars.patch1215_show_maximized_titlebars.patch
1316-capture-before-unmap.patch1316-capture-before-unmap.patch
1417-workspace-switcher-cycle.patch
1490_autotools.patch1590_autotools.patch
1599_ltmain_as-needed.patch1699_ltmain_as-needed.patch

Subscribers

People subscribed via source and target branches

to all changes: