So, code-wise it looks ok as well. There are some places that still need cleaning up - there are some leftover comments needing removal, or things like class pre-declaration (for the classes we actually remove and not use) - but my GOD let's not add any more changes into this already-too-big changeset. Let's merge it as it is and use future commits for additional clean-ups.
While we're at it, I guess it would be nice to start writing unit-tests again - especially that we have the whole preedit-text test suite disabled and out-of-date.
So, code-wise it looks ok as well. There are some places that still need cleaning up - there are some leftover comments needing removal, or things like class pre-declaration (for the classes we actually remove and not use) - but my GOD let's not add any more changes into this already-too-big changeset. Let's merge it as it is and use future commits for additional clean-ups.
While we're at it, I guess it would be nice to start writing unit-tests again - especially that we have the whole preedit-text test suite disabled and out-of-date.