Merge lp:~bfiller/telephony-service/fix-1392222 into lp:telephony-service/rtm-14.09

Proposed by Bill Filler
Status: Merged
Approved by: Bill Filler
Approved revision: 909
Merged at revision: 909
Proposed branch: lp:~bfiller/telephony-service/fix-1392222
Merge into: lp:telephony-service/rtm-14.09
Diff against target: 28 lines (+3/-1)
1 file modified
libtelephonyservice/ringtone.cpp (+3/-1)
To merge this branch: bzr merge lp:~bfiller/telephony-service/fix-1392222
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+243843@code.launchpad.net

Commit message

fix ringtone change not getting applied until restart

Description of the change

fix ringtone change not getting applied until restart

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libtelephonyservice/ringtone.cpp'
--- libtelephonyservice/ringtone.cpp 2014-09-03 06:23:48 +0000
+++ libtelephonyservice/ringtone.cpp 2014-12-05 17:07:35 +0000
@@ -27,7 +27,6 @@
27 mMessageAudioPlayer(NULL)27 mMessageAudioPlayer(NULL)
28{28{
29 mCallAudioPlaylist.setPlaybackMode(QMediaPlaylist::Loop);29 mCallAudioPlaylist.setPlaybackMode(QMediaPlaylist::Loop);
30 mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));
31 mCallAudioPlaylist.setCurrentIndex(0);30 mCallAudioPlaylist.setCurrentIndex(0);
32 mVibrateEffect.setDuration(500);31 mVibrateEffect.setDuration(500);
33}32}
@@ -46,6 +45,8 @@
46 return;45 return;
47 }46 }
4847
48 // pick up the new ringtone in case it changed in the meantime
49 mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));
49 mCallAudioPlayer = new QMediaPlayer(this);50 mCallAudioPlayer = new QMediaPlayer(this);
50 mCallAudioPlayer->setAudioRole(QMediaPlayer::AlertRole);51 mCallAudioPlayer->setAudioRole(QMediaPlayer::AlertRole);
51 mCallAudioPlayer->setPlaylist(&mCallAudioPlaylist);52 mCallAudioPlayer->setPlaylist(&mCallAudioPlaylist);
@@ -60,6 +61,7 @@
60 mCallAudioPlayer->deleteLater();61 mCallAudioPlayer->deleteLater();
61 mCallAudioPlayer = NULL;62 mCallAudioPlayer = NULL;
62 }63 }
64 mCallAudioPlaylist.clear();
63}65}
6466
65void RingtoneWorker::playIncomingMessageSound()67void RingtoneWorker::playIncomingMessageSound()

Subscribers

People subscribed via source and target branches