Merge lp:~bfiller/telephony-service/fix-1392222 into lp:telephony-service/rtm-14.09

Proposed by Bill Filler
Status: Merged
Approved by: Bill Filler
Approved revision: 909
Merged at revision: 909
Proposed branch: lp:~bfiller/telephony-service/fix-1392222
Merge into: lp:telephony-service/rtm-14.09
Diff against target: 28 lines (+3/-1)
1 file modified
libtelephonyservice/ringtone.cpp (+3/-1)
To merge this branch: bzr merge lp:~bfiller/telephony-service/fix-1392222
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+243843@code.launchpad.net

Commit message

fix ringtone change not getting applied until restart

Description of the change

fix ringtone change not getting applied until restart

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libtelephonyservice/ringtone.cpp'
2--- libtelephonyservice/ringtone.cpp 2014-09-03 06:23:48 +0000
3+++ libtelephonyservice/ringtone.cpp 2014-12-05 17:07:35 +0000
4@@ -27,7 +27,6 @@
5 mMessageAudioPlayer(NULL)
6 {
7 mCallAudioPlaylist.setPlaybackMode(QMediaPlaylist::Loop);
8- mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));
9 mCallAudioPlaylist.setCurrentIndex(0);
10 mVibrateEffect.setDuration(500);
11 }
12@@ -46,6 +45,8 @@
13 return;
14 }
15
16+ // pick up the new ringtone in case it changed in the meantime
17+ mCallAudioPlaylist.addMedia(QUrl::fromLocalFile(GreeterContacts::instance()->incomingCallSound()));
18 mCallAudioPlayer = new QMediaPlayer(this);
19 mCallAudioPlayer->setAudioRole(QMediaPlayer::AlertRole);
20 mCallAudioPlayer->setPlaylist(&mCallAudioPlaylist);
21@@ -60,6 +61,7 @@
22 mCallAudioPlayer->deleteLater();
23 mCallAudioPlayer = NULL;
24 }
25+ mCallAudioPlaylist.clear();
26 }
27
28 void RingtoneWorker::playIncomingMessageSound()

Subscribers

People subscribed via source and target branches