Code review comment for lp:~bfiller/phone-app/fix-ringtone

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

As self is being declared static, it will only be initialized once in the original code. The change itself is not wrong, it can be implemented that way too, but the result is the same and in my personal opinion the original code is more simple as it is contained all in the function code.

review: Disapprove

« Back to merge proposal