Code review comment for lp:~bfiller/gallery-app/click-support

Revision history for this message
Bill Filler (bfiller) wrote :

dropping the --fullscreen arg from the exec causes the app to not launched fullscreen on the devices anymore. it needs to be fullscreen so the top panel is hidden when a photo is viewed but no current way to do that dynamically - has to be all or nothing..

so, what we really want is to have the app determine which device it's running on and do fullscreen mode internally. it's correct to remove it from the desktop file/exec but we need to add the support in the code to run it fullscreen if !DESKTOP_MODE

review: Needs Fixing

« Back to merge proposal