Zim

Code review comment for lp:~beutlin/zim/table-plugin

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Hi Tobias,

After studying the code in more detail I think it can be merged right away.

My only point of discussion is the format of tables in the default wiki format. I wonder of the choice of using the "{{{table ... }}}" object syntax is the right choice. Especially sine you build the table format more as a core structure into the parser and only the widget is in the plugin.

My proposal then would be to support tables in the native wiki syntax without the "{{{ ... }}}" object wrapper. I would propose to use the same format as in markdown [1] and possibly also support the wiki creole syntax [2]. Fine to allow reading the object syntax, but when writing we should just use the native format.

Wanted to make the change myself and then merge. But I don't know what to do with the "wraps" attribute. What would be a logical syntax to add that in a markdown like table format ?

Regards,

Jaap

[1] https://help.github.com/articles/github-flavored-markdown/
[2] http://www.wikicreole.org/wiki/Creole1.0#Tables

review: Needs Information

« Back to merge proposal