1) I'm not sure what checking in branch.py and in transport.py really gains you -- I think just checking in branch.py would be OK?
2) '== "False"' as a condition check is pretty icky, I think at least 'false' should be accepted too. It's unfortunate that bzrlib doesn't let you at the as_bool method of configobj. Perhaps we can just paste in a version of that as a standalone function? And file a bug on bzrlib.
I guess this is bb:comment... two points:
1) I'm not sure what checking in branch.py and in transport.py really gains you -- I think just checking in branch.py would be OK?
2) '== "False"' as a condition check is pretty icky, I think at least 'false' should be accepted too. It's unfortunate that bzrlib doesn't let you at the as_bool method of configobj. Perhaps we can just paste in a version of that as a standalone function? And file a bug on bzrlib.
Let's chat about these points on IRC sometime.