Code review comment for lp:~beuno/loggerhead/serve-config
Revision history for this message
| Matt Nordhoff (mnordhoff) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Without doing a real review, I spotted a couple trivial whitespace issues:
* The copyright headers tend to have 2 spaces between "2009" and "Canonical".
* TestEmptyBranch's docstring starts with a space.
Aside from that, one question: What about using 403 Forbidden for hidden branches instead of 404 Not Found? Obviously it'd reveal their existence, but it's also more true to a setting named "serve_http = False". Sort of. Maybe. :D