Merge lp:~beuno/loggerhead/bundles into lp:loggerhead

[Martin Albisetti]

[Michael Hudson-Doyle (mwhudson)]

Martin Albisetti wrote:
> You have been requested to review the proposed merge of ~beuno/loggerhead/bundles into ~loggerhead-team/loggerhead/trunk.

I think the conditions and the diff links should be done by inspecting
the change object -- show the diff against the left-most parent of the
change, something like 'h.get_revno(change.parents[0].revid)', rather
than the navigation. The effect is the same, but this would cause fewer
wtfs :)

Hm, actually I think the diff should be to just diff/<revno> in the
default case and to diff/<compare_revid>/<cur revno> when there is a
compare_revid -- this should be an easy change to make, I think.

Cheers,
mwh

[lp:~beuno/loggerhead/bundles]

215. By Martin Albisetti on 2008-08-13

Use something saner as a condition to show diff download link

[Martin Albisetti (beuno)]

On Tue, Aug 12, 2008 at 9:27 PM, Michael Hudson
<email address hidden> wrote:
> I think the conditions and the diff links should be done by inspecting
> the change object -- show the diff against the left-most parent of the
> change, something like 'h.get_revno(change.parents[0].revid)', rather
> than the navigation. The effect is the same, but this would cause fewer
> wtfs :)

Done.

> Hm, actually I think the diff should be to just diff/<revno> in the
> default case and to diff/<compare_revid>/<cur revno> when there is a
> compare_revid -- this should be an easy change to make, I think.

Done.

Thanks for the review!

--
Martin

[lp:~beuno/loggerhead/bundles]

216. By Martin Albisetti on 2008-08-14

Make the compare revid optional

217. By Martin Albisetti on 2008-08-14

Actually use compare_revid

[Tim Penhey (thumper)]

Looks good to me.

review: Approve