Code review comment for lp:~beuno/loggerhead/bundles

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Martin Albisetti wrote:
> You have been requested to review the proposed merge of ~beuno/loggerhead/bundles into ~loggerhead-team/loggerhead/trunk.

I think the conditions and the diff links should be done by inspecting
the change object -- show the diff against the left-most parent of the
change, something like 'h.get_revno(change.parents[0].revid)', rather
than the navigation. The effect is the same, but this would cause fewer
wtfs :)

Hm, actually I think the diff should be to just diff/<revno> in the
default case and to diff/<compare_revid>/<cur revno> when there is a
compare_revid -- this should be an easy change to make, I think.


« Back to merge proposal