Checkbox Provider - Base

Merge ~bettyl/plainbox-provider-checkbox:remove-thunderbolt-tests into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bettyl/plainbox-provider-checkbox
  3. remove-thunderbolt-tests
  4. Merge into master
Proposed by Betty Lin
Status: Merged
Approved by: Betty Lin
Approved revision: ec48149dc815478ffc92e07e8d9ccebe1667549b
Merged at revision: 0ecb122c7d5a59f21ff041009712cd784bfa10c4
Proposed branch: ~bettyl/plainbox-provider-checkbox:remove-thunderbolt-tests
Merge into: plainbox-provider-checkbox:master
Diff against target: 123 lines (+0/-34)
2 files modified
units/monitor/test-plan.pxu (+0/-22)
units/thunderbolt/test-plan.pxu (+0/-12)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Betty Lin (community) Needs Resubmitting
Jerry Kao (community) Approve
Sylvain Pineau Pending
Review via email: mp+377114@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jerry Kao (jerry.kao) wrote :

Thanks Betty.

We also need to remove the following tests in monitor and audio.

monitor/1_thunderbolt_.*
audio/1_playback_thunderbolt_.*
thunderbolt/daisy-chain
after-suspend-manual-monitor/1_thunderbolt_.*
after-suspend-manual-audio/1_playback_thunderbolt_.*
after-suspend-manual-thunderbolt/daisy-chain

monitor/2_thunderbolt_.*
audio/2_playback_thunderbolt_.*
after-suspend-manual-monitor/2_thunderbolt_.*
after-suspend-manual-audio/2_playback_thunderbolt_.*
after-suspend-manual-thunderbolt/daisy-chain

review: Needs Fixing
Revision history for this message
Betty Lin (bettyl) wrote :

@Jerry

Updated, thanks!

review: Needs Resubmitting
Revision history for this message
Jerry Kao (jerry.kao) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

I would prefer if the lines were removed rather than commented out. No problem with the change though.

review: Needs Fixing
Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan, because of thunderbolt 4 is coming soon, so I kept them there

Revision history for this message
Jonathan Cave (jocave) wrote :

I think that commenting them out is just uncertainty that is preferable to not have to manage, I would choose one of 1) delete 2) change to thunderbolt4 now 3) leave as is

Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan, got it, let's remove them now and add thunderbolt 4 related tests when they arrive, thanks.

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/monitor/test-plan.pxu b/units/monitor/test-plan.pxu
index fd4686a..aa99f3f 100644
--- a/units/monitor/test-plan.pxu
+++ b/units/monitor/test-plan.pxu
@@ -36,9 +36,6 @@ include:
36 monitor/1_dvi_.* certification-status=blocker36 monitor/1_dvi_.* certification-status=blocker
37 monitor/1_hdmi_.* certification-status=blocker37 monitor/1_hdmi_.* certification-status=blocker
38 audio/1_playback_hdmi_.* certification-status=blocker38 audio/1_playback_hdmi_.* certification-status=blocker
39 monitor/1_thunderbolt_.* certification-status=blocker
40 audio/1_playback_thunderbolt_.* certification-status=blocker
41 thunderbolt/daisy-chain certification-status=blocker
42 monitor/1_thunderbolt3_.* certification-status=non-blocker39 monitor/1_thunderbolt3_.* certification-status=non-blocker
43 audio/1_playback_thunderbolt3_.* certification-status=non-blocker40 audio/1_playback_thunderbolt3_.* certification-status=non-blocker
44 thunderbolt3/daisy-chain certification-status=non-blocker41 thunderbolt3/daisy-chain certification-status=non-blocker
@@ -65,9 +62,6 @@ include:
65 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker62 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker
66 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker63 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker
67 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker64 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker
68 after-suspend-manual-monitor/1_thunderbolt_.* certification-status=blocker
69 after-suspend-manual-audio/1_playback_thunderbolt_.* certification-status=blocker
70 after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
71 after-suspend-manual-monitor/1_thunderbolt3_.* certification-status=non-blocker65 after-suspend-manual-monitor/1_thunderbolt3_.* certification-status=non-blocker
72 after-suspend-manual-audio/1_playback_thunderbolt3_.* certification-status=non-blocker66 after-suspend-manual-audio/1_playback_thunderbolt3_.* certification-status=non-blocker
73 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker67 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker
@@ -116,8 +110,6 @@ include:
116 monitor/2_dvi_.* certification-status=blocker110 monitor/2_dvi_.* certification-status=blocker
117 monitor/2_hdmi_.* certification-status=blocker111 monitor/2_hdmi_.* certification-status=blocker
118 audio/2_playback_hdmi_.* certification-status=blocker112 audio/2_playback_hdmi_.* certification-status=blocker
119 monitor/2_thunderbolt_.* certification-status=blocker
120 audio/2_playback_thunderbolt_.* certification-status=blocker
121 monitor/2_thunderbolt3_.* certification-status=non-blocker113 monitor/2_thunderbolt3_.* certification-status=non-blocker
122 audio/2_playback_thunderbolt3_.* certification-status=non-blocker114 audio/2_playback_thunderbolt3_.* certification-status=non-blocker
123 monitor/2_vga_.* certification-status=blocker115 monitor/2_vga_.* certification-status=blocker
@@ -153,9 +145,6 @@ include:
153 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker145 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker
154 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker146 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker
155 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker147 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker
156 after-suspend-manual-monitor/2_thunderbolt_.* certification-status=blocker
157 after-suspend-manual-audio/2_playback_thunderbolt_.* certification-status=blocker
158 after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
159 after-suspend-manual-monitor/2_thunderbolt3_.* certification-status=non-blocker148 after-suspend-manual-monitor/2_thunderbolt3_.* certification-status=non-blocker
160 after-suspend-manual-audio/2_playback_thunderbolt3_.* certification-status=non-blocker149 after-suspend-manual-audio/2_playback_thunderbolt3_.* certification-status=non-blocker
161 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker150 after-suspend-manual-thunderbolt3/daisy-chain certification-status=non-blocker
@@ -191,9 +180,6 @@ include:
191 monitor/1_dvi_.* certification-status=blocker180 monitor/1_dvi_.* certification-status=blocker
192 monitor/1_hdmi_.* certification-status=blocker181 monitor/1_hdmi_.* certification-status=blocker
193 audio/1_playback_hdmi_.* certification-status=blocker182 audio/1_playback_hdmi_.* certification-status=blocker
194 monitor/1_thunderbolt_.* certification-status=blocker
195 audio/1_playback_thunderbolt_.* certification-status=blocker
196 thunderbolt/daisy-chain certification-status=blocker
197 monitor/1_vga_.* certification-status=blocker183 monitor/1_vga_.* certification-status=blocker
198 monitor/1_multi-head_.* certification-status=blocker184 monitor/1_multi-head_.* certification-status=blocker
199bootstrap_include:185bootstrap_include:
@@ -216,9 +202,6 @@ include:
216 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker202 after-suspend-manual-monitor/1_dvi_.* certification-status=blocker
217 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker203 after-suspend-manual-monitor/1_hdmi_.* certification-status=blocker
218 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker204 after-suspend-manual-audio/1_playback_hdmi_.* certification-status=blocker
219 after-suspend-manual-monitor/1_thunderbolt_.* certification-status=blocker
220 after-suspend-manual-audio/1_playback_thunderbolt_.* certification-status=blocker
221 after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
222 after-suspend-manual-monitor/1_vga_.* certification-status=blocker205 after-suspend-manual-monitor/1_vga_.* certification-status=blocker
223 after-suspend-manual-monitor/1_multi-head_.* certification-status=blocker206 after-suspend-manual-monitor/1_multi-head_.* certification-status=blocker
224bootstrap_include:207bootstrap_include:
@@ -241,8 +224,6 @@ include:
241 monitor/2_dvi_.* certification-status=blocker224 monitor/2_dvi_.* certification-status=blocker
242 monitor/2_hdmi_.* certification-status=blocker225 monitor/2_hdmi_.* certification-status=blocker
243 audio/2_playback_hdmi_.* certification-status=blocker226 audio/2_playback_hdmi_.* certification-status=blocker
244 monitor/2_thunderbolt_.* certification-status=blocker
245 audio/2_playback_thunderbolt_.* certification-status=blocker
246 monitor/2_vga_.* certification-status=blocker227 monitor/2_vga_.* certification-status=blocker
247 monitor/2_multi-head_.* certification-status=blocker228 monitor/2_multi-head_.* certification-status=blocker
248bootstrap_include:229bootstrap_include:
@@ -265,9 +246,6 @@ include:
265 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker246 after-suspend-manual-monitor/2_dvi_.* certification-status=blocker
266 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker247 after-suspend-manual-monitor/2_hdmi_.* certification-status=blocker
267 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker248 after-suspend-manual-audio/2_playback_hdmi_.* certification-status=blocker
268 after-suspend-manual-monitor/2_thunderbolt_.* certification-status=blocker
269 after-suspend-manual-audio/2_playback_thunderbolt_.* certification-status=blocker
270 after-suspend-manual-thunderbolt/daisy-chain certification-status=blocker
271 after-suspend-manual-monitor/2_vga_.* certification-status=blocker249 after-suspend-manual-monitor/2_vga_.* certification-status=blocker
272 after-suspend-manual-monitor/2_multi-head_.* certification-status=blocker250 after-suspend-manual-monitor/2_multi-head_.* certification-status=blocker
273bootstrap_include:251bootstrap_include:
diff --git a/units/thunderbolt/test-plan.pxu b/units/thunderbolt/test-plan.pxu
index 75aa0ac..5015cde 100644
--- a/units/thunderbolt/test-plan.pxu
+++ b/units/thunderbolt/test-plan.pxu
@@ -23,9 +23,6 @@ _name: Thunderbolt tests (Manual)
23_description:23_description:
24 Thunderbolt tests (Manual)24 Thunderbolt tests (Manual)
25include:25include:
26 thunderbolt/insert certification-status=blocker
27 thunderbolt/storage-test certification-status=blocker
28 thunderbolt/remove certification-status=blocker
29 thunderbolt3/insert certification-status=non-blocker26 thunderbolt3/insert certification-status=non-blocker
30 thunderbolt3/storage-test certification-status=non-blocker27 thunderbolt3/storage-test certification-status=non-blocker
31 thunderbolt3/remove certification-status=non-blocker28 thunderbolt3/remove certification-status=non-blocker
@@ -43,9 +40,6 @@ unit: test plan
43_name: Thunderbolt tests (certification blockers only)40_name: Thunderbolt tests (certification blockers only)
44_description: Thunderbolt tests (certification blockers only)41_description: Thunderbolt tests (certification blockers only)
45include:42include:
46 thunderbolt/insert certification-status=blocker
47 thunderbolt/storage-test certification-status=blocker
48 thunderbolt/remove certification-status=blocker
4943
50id: after-suspend-thunderbolt-cert-manual44id: after-suspend-thunderbolt-cert-manual
51unit: test plan45unit: test plan
@@ -53,9 +47,6 @@ _name: Thunderbolt tests (after suspend Manual)
53_description:47_description:
54 Thunderbolt tests (after suspend Manual)48 Thunderbolt tests (after suspend Manual)
55include:49include:
56 after-suspend-manual-thunderbolt/insert certification-status=blocker
57 after-suspend-manual-thunderbolt/storage-test certification-status=blocker
58 after-suspend-manual-thunderbolt/remove certification-status=blocker
59 after-suspend-manual-thunderbolt3/insert certification-status=non-blocker50 after-suspend-manual-thunderbolt3/insert certification-status=non-blocker
60 after-suspend-manual-thunderbolt3/storage-test certification-status=non-blocker51 after-suspend-manual-thunderbolt3/storage-test certification-status=non-blocker
61 after-suspend-manual-thunderbolt3/remove certification-status=non-blocker52 after-suspend-manual-thunderbolt3/remove certification-status=non-blocker
@@ -65,8 +56,5 @@ unit: test plan
65_name: Thunderbolt tests (after suspend - certification blockers only)56_name: Thunderbolt tests (after suspend - certification blockers only)
66_description: Thunderbolt tests (after suspend - certification blockers only)57_description: Thunderbolt tests (after suspend - certification blockers only)
67include:58include:
68 after-suspend-manual-thunderbolt/insert certification-status=blocker
69 after-suspend-manual-thunderbolt/storage-test certification-status=blocker
70 after-suspend-manual-thunderbolt/remove certification-status=blocker
7159
7260

Subscribers

People subscribed via source and target branches