Checkbox Provider - Base

Merge ~bettyl/plainbox-provider-checkbox:remove-battery-info-hotkey into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bettyl/plainbox-provider-checkbox
  3. remove-battery-info-hotkey
  4. Merge into master
Proposed by Betty Lin
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 26bb407e9dcb3653b0d1210262255ab5f6d2c6f0
Merged at revision: de9378161947cb84c6eb6593907a05d46eaed512
Proposed branch: ~bettyl/plainbox-provider-checkbox:remove-battery-info-hotkey
Merge into: plainbox-provider-checkbox:master
Diff against target: 36 lines (+0/-4)
1 file modified
units/keys/test-plan.pxu (+0/-4)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Maciej Kisielewski Approve
Review via email: mp+370030@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

LGTM, +1.
Great commit message <3

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [01:32:31] starting container
Device project added to bionic-testing
[xenial] [01:32:34] starting container
Device project added to xenial-testing
[bionic] [01:32:44] provisioning container
[xenial] [01:32:44] provisioning container
[bionic] [01:32:51] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/f4F2tHkpNx/
[bionic] [01:32:53] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [01:33:04] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [01:34:16] container-tests-provider-checkbox: PASS
[xenial] [01:34:16] Fixing file permissions in source directory
[xenial] [01:34:16] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [07:40:45] starting container
[xenial] [07:40:45] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[bionic] [07:40:57] provisioning container
[xenial] [07:40:57] provisioning container
[bionic] [07:41:08] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/qNqvCffzqt/
[bionic] [07:41:10] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [07:41:18] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [07:42:30] container-tests-provider-checkbox: PASS
[xenial] [07:42:30] Fixing file permissions in source directory
[xenial] [07:42:31] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [07:44:18] starting container
[xenial] [07:44:18] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[xenial] [07:44:30] provisioning container
[bionic] [07:44:31] provisioning container
[bionic] [07:44:42] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/3qvv25BrfJ/
[bionic] [07:44:44] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [07:44:52] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [07:46:10] container-tests-provider-checkbox: PASS
[xenial] [07:46:10] Fixing file permissions in source directory
[xenial] [07:46:10] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/keys/test-plan.pxu b/units/keys/test-plan.pxu
index c75a32a..38386ef 100644
--- a/units/keys/test-plan.pxu
+++ b/units/keys/test-plan.pxu
@@ -16,7 +16,6 @@ _description:
16include:16include:
17 keys/lock-screen certification-status=blocker17 keys/lock-screen certification-status=blocker
18 keys/super certification-status=blocker18 keys/super certification-status=blocker
19 keys/battery-info certification-status=blocker
20 keys/brightness certification-status=blocker19 keys/brightness certification-status=blocker
21 keys/media-control certification-status=blocker20 keys/media-control certification-status=blocker
22 keys/mute certification-status=blocker21 keys/mute certification-status=blocker
@@ -42,7 +41,6 @@ _description:
42include:41include:
43 after-suspend-manual-keys/lock-screen certification-status=blocker42 after-suspend-manual-keys/lock-screen certification-status=blocker
44 after-suspend-manual-keys/super certification-status=blocker43 after-suspend-manual-keys/super certification-status=blocker
45 after-suspend-manual-keys/battery-info certification-status=blocker
46 after-suspend-manual-keys/brightness certification-status=blocker44 after-suspend-manual-keys/brightness certification-status=blocker
47 after-suspend-manual-keys/media-control certification-status=blocker45 after-suspend-manual-keys/media-control certification-status=blocker
48 after-suspend-manual-keys/mute certification-status=blocker46 after-suspend-manual-keys/mute certification-status=blocker
@@ -61,7 +59,6 @@ _description:
61include:59include:
62 keys/lock-screen certification-status=blocker60 keys/lock-screen certification-status=blocker
63 keys/super certification-status=blocker61 keys/super certification-status=blocker
64 keys/battery-info certification-status=blocker
65 keys/brightness certification-status=blocker62 keys/brightness certification-status=blocker
66 keys/media-control certification-status=blocker63 keys/media-control certification-status=blocker
67 keys/mute certification-status=blocker64 keys/mute certification-status=blocker
@@ -79,7 +76,6 @@ _description:
79include:76include:
80 after-suspend-manual-keys/lock-screen certification-status=blocker77 after-suspend-manual-keys/lock-screen certification-status=blocker
81 after-suspend-manual-keys/super certification-status=blocker78 after-suspend-manual-keys/super certification-status=blocker
82 after-suspend-manual-keys/battery-info certification-status=blocker
83 after-suspend-manual-keys/brightness certification-status=blocker79 after-suspend-manual-keys/brightness certification-status=blocker
84 after-suspend-manual-keys/media-control certification-status=blocker80 after-suspend-manual-keys/media-control certification-status=blocker
85 after-suspend-manual-keys/mute certification-status=blocker81 after-suspend-manual-keys/mute certification-status=blocker

Subscribers

People subscribed via source and target branches