Merge ~bettyl/plainbox-provider-checkbox:add-after-suspend-manual-c-to-a-adapter-ethernet into plainbox-provider-checkbox:master

Proposed by Betty Lin
Status: Merged
Approved by: Jonathan Cave
Approved revision: 13d2ec0e8409fc06a2e071e126a62e925cb7a914
Merged at revision: 1beb1bc65a52f9f8a3a216786feb5bba164d6712
Proposed branch: ~bettyl/plainbox-provider-checkbox:add-after-suspend-manual-c-to-a-adapter-ethernet
Merge into: plainbox-provider-checkbox:master
Diff against target: 24 lines (+2/-0)
2 files modified
units/usb/test-plan.pxu (+1/-0)
units/usb/usb-c.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+368637@code.launchpad.net

Description of the change

I have tested this in a stock Ubuntu 18.04 and the jobs "com.canonical.certification::after-suspend-manual-usb-c/c-to-ethernet-adapter-insert" displayed, when I do:
When I do:
$ checkbox-cli list-bootstrapped com.canonical.ce::somerville-iev-full

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/usb/test-plan.pxu b/units/usb/test-plan.pxu
index 63c62b8..e6a9165 100644
--- a/units/usb/test-plan.pxu
+++ b/units/usb/test-plan.pxu
@@ -102,6 +102,7 @@ include:
102 after-suspend-manual-usb-c/insert certification-status=blocker102 after-suspend-manual-usb-c/insert certification-status=blocker
103 after-suspend-manual-usb-c/storage-automated certification-status=blocker103 after-suspend-manual-usb-c/storage-automated certification-status=blocker
104 after-suspend-manual-usb-c/remove certification-status=blocker104 after-suspend-manual-usb-c/remove certification-status=blocker
105 after-suspend-manual-usb-c/c-to-ethernet-adapter-insert
105106
106id: usb-cert-blockers107id: usb-cert-blockers
107unit: test plan108unit: test plan
diff --git a/units/usb/usb-c.pxu b/units/usb/usb-c.pxu
index cf7c5f6..0d709e2 100644
--- a/units/usb/usb-c.pxu
+++ b/units/usb/usb-c.pxu
@@ -189,6 +189,7 @@ estimated_duration: 30
189189
190id: usb-c/c-to-ethernet-adapter-insert190id: usb-c/c-to-ethernet-adapter-insert
191plugin: user-interact191plugin: user-interact
192flags: also-after-suspend-manual
192category_id: com.canonical.plainbox::usb193category_id: com.canonical.plainbox::usb
193imports: from com.canonical.plainbox import manifest194imports: from com.canonical.plainbox import manifest
194requires: manifest.has_usb_type_c == 'True'195requires: manifest.has_usb_type_c == 'True'

Subscribers

People subscribed via source and target branches