Code review comment for lp:~berolinux/linaro-image-tools/android-iMX53

On Tue, 26 Jul 2011 15:22:38 -0000, Guilherme Salgado <email address hidden> wrote:
> > - try:
> > - cmd_runner.run(['umount', boot_disk], as_root=True).wait()
> > - except cmd_runner.SubcommandNonZeroReturnValue:
> > - pass
>
> This change is no longer necessary and will actually break l-a-m-c as of
> r388. You might want to use the new partition_mounted() context manager
> here although that can be done later.

This was because the branch was based on his fix for that problem, and
it wasn't set as a prerequisite.

I think that we should get answers for the other questions and decide:

  1) Is what I merged unsuitable for this release?
  2) Should anything be changed for next release to have a better
  codebase?

Thanks,

James