Ubuntu
libofx package

Code review comment for lp:~benoitg/ubuntu/natty/libofx/libofx.new-upstream-fix-661809-629996

  1. Natty (11.04)
  2. libofx.new-upstream-fix-661809-629996
  3. Merge into natty
Revision history for this message
Michael Terry (mterry) wrote :

Hello! Thanks for the attention to libofx, looks like good stuff.

However, we're too close to natty's release to squeeze this in. And the changes are too invasive (changing source format, etc) to use as an SRU.

If the specific patches are very important, you can file an SRU for them that includes just the bug fix patches. See https://wiki.ubuntu.com/StableReleaseUpdates

Otherwise, these changes would be able to go into oneiric.

However! Even then, your packaging changes (source format, watch, etc) add quite a bit of a delta with Debian. It would be better to send those patches upstream to Debian than introduce them only in Ubuntu.

Lastly, I don't actually see any changes in this merge to the debian/ directory. Where are the packaging changes?

review: Needs Fixing

« Back to merge proposal