Code review comment for lp:~benji/lpsetup/add-get-subcommand

Revision history for this message
Brad Crittenden (bac) wrote :

* Please add a period to the file docstring.

* The LP_REPOS[1] vs [0] part in setup_codebase is confusing. Perhaps if you assigned it to a descriptive variable and used it in the command it might be easier to understand/self-documenting.

* Do we need to specify --2a for init-repo?

I know those existed in the code you refactored.

Otherwise it looks great.

review: Approve

« Back to merge proposal