Code review comment for lp:~benji/lazr.restful/size-link

On Fri, Aug 6, 2010 at 1:49 PM, Gary Poster <email address hidden> wrote:
> The NEWS file has both the British and American spellings of "behavior."
> Officially, Canonical uses British spellings.  I generally stick with
> American spellings for lazr packages, since that's easier for all or most of
> the main contributors they have.  At the very least, for one NEWS entry, I'd
> like to stick to one approach. :-)

You can colour me honoured by your skilful counselling.

> The name "total_size_only" appears several times.  Its behavior is not
> clear to me.  The ``if not self.total_size_only:`` lines that appear
> in _operations.py particularly confuse me.  I'd like to see some
> comments, and I'd like it explained in appropriate docstrings.  It
> also makes me question the name in batchnavigator, TBH, but maybe
> there's not a better option.  What does it mean?

I'll try to come up with a better name. The "if not" bit is especially
hard to grok.
--
Benji York