Code review comment for lp:~benji/lazr.restful/bug-854695

Revision history for this message
Graham Binns (gmb) wrote :

Hi Benji,

Nice branch, one really minor nitpick:

97 + self.fail('The resource should not have generated an '
98 + 'AttributeError. This is probably because something was '
99 + 'expecting the exception to have a __traceback__ attribute.')

should be formatted as:

            self.fail(
                'The resource should not have generated an '
                'AttributeError. This is probably because something was '
                'expecting the exception to have a __traceback__ attribute.')

(It also has a double-space in there before the "This" that it doesn't need).

review: Approve (code)

« Back to merge proposal