Code review comment for lp:~benji/lazr.restful/bug-413174

Revision history for this message
Gary Poster (gary) wrote :

Very nice catch with the check for isinstance of BaseException.

I question the view pattern for the registration and lookup--using "index.html" as the distinguishing marker. I'd prefer a custom interface myself. If, in retrospect, you agree, great. If not, I can see where you are coming from: leave as is.

We need a linter. Either ``from types import ClassType`` in src/lazr/restful/ shouldn't be there now, or it should have been caught earlier. Which is it?

In, you say "# Bug 11512 describes the possibility of controlling the HTTP status of...." I think you mean bug 631711.

review: Approve

« Back to merge proposal