Merge lp:~benji/launchpad/bug-954319 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Benji York |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14954 |
Proposed branch: | lp:~benji/launchpad/bug-954319 |
Merge into: | lp:launchpad |
Diff against target: |
28 lines (+3/-1) 1 file modified
lib/lp/services/database/tests/test_readonly.py (+3/-1) |
To merge this branch: | bzr merge lp:~benji/launchpad/bug-954319 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+97491@code.launchpad.net |
Commit message
fix a test isolation bug that causes read-only mode to get stuck on when the test are run in a semi-random order (as when running them in parallel)
Description of the change
This branch fixes a test isolation bug that causes read-only mode to get stuck on when the test are run in a semi-random order (as when running them in parallel).
The problem is that a test request was leaking out of these tests so the fix was to end the current interaction in the tearDown.
Both the subset of the tests that exhibited the problem (see linked bug) and a much larger test run (comprising half of all the tests) nolonger provke the bug.
I also fixed a bit trailing whitespace lint in lib/lp/