Merge lp:~benji/launchpad/bug-719637 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Benji York |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13173 |
Proposed branch: | lp:~benji/launchpad/bug-719637 |
Merge into: | lp:launchpad |
Diff against target: |
51 lines (+30/-1) 2 files modified
lib/canonical/launchpad/webapp/errorlog.py (+6/-1) lib/canonical/launchpad/webapp/tests/test_errorlog.py (+24/-0) |
To merge this branch: | bzr merge lp:~benji/launchpad/bug-719637 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email: mp+63159@code.launchpad.net |
Commit message
[r=abentley][bug=719637] fix a variant of 719637 by not generating OOPSes on otherwise ignorable exceptions if there is no referer
Description of the change
Bug 719637 was mostly fixed along with bug 730393. However, a new incarnation of the bug was introduced at that time that caused NotFound (and similar errors) to OOPS if no referer is set. This happens in production (e.g., OOPS-1970CF506). This branch fixes this.
The operative change is the "if" statement added to lib/canonical/
The new tests exercise the different ways the if can be traversed.
The new tests can be run with
bin/test -c -m canonical.
The make lint report is clean.