Code review comment for lp:~benji/juju-gui/sandboxify-tests

Reviewers: mp+198410_code.launchpad.net,

Message:
Pre-review comments.

https://codereview.appspot.com/40190043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode408
Makefile:408: # of this target when called by lbox. Please do not
change.
Typo fix, I think.

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode445
Makefile:445: PYTHONPATH=lib virtualenv/bin/python
test/test_websocketreplay.py
We were using the system Python here.

https://codereview.appspot.com/40190043/diff/1/Makefile#newcode458
Makefile:458: # Wait for the display to be accessible.
Avoid racing with Xvfb to start up.

https://codereview.appspot.com/40190043/diff/1/test/browser.py
File test/browser.py (left):

https://codereview.appspot.com/40190043/diff/1/test/browser.py#oldcode214
test/browser.py:214: printerr('* Platform: local
{}'.format(get_platform(driver)))
This was annoying and non-useful.

https://codereview.appspot.com/40190043/diff/1/test/test_browser.py
File test/test_browser.py (right):

https://codereview.appspot.com/40190043/diff/1/test/test_browser.py#newcode1
test/test_browser.py:1: # This file is part of the Juju GUI, which lets
users view and manage Juju
These tests were moved here, unchanged.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (left):

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#oldcode25
test/test_charm_running.py:25: class TestBasics(browser.TestCase):
These were moved elsewhere.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#oldcode277
test/test_charm_running.py:277: class
TestAuthentication(browser.TestCase):
Moved.

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/40190043/diff/1/test/test_charm_running.py#newcode192
test/test_charm_running.py:192: self.deploy('mysql')
This change made the tests start working when the GUI is not run from a
charm (as in the sandbox).

Description:
Add the ability to run local browser tests.

Some existing tests were moved from charm-requiring tests to local
browser
tests.

https://code.launchpad.net/~benji/juju-gui/sandboxify-tests/+merge/198410

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/40190043/

Affected files (+131, -74 lines):
   M HACKING
   M Makefile
   A [revision details]
   M test/browser.py
   A test/test_browser.py
   M test/test_browser_errors.py
   M test/test_charm_running.py
   M test/test_deploy_charm_for_testing.py