Land with changes.
Extremely nice branch, Benji. Thank you.
Gary
https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js File app/views/topology/relation.js (right):
https://codereview.appspot.com/7206047/diff/1/app/views/topology/relation.js#newcode834 app/views/topology/relation.js:834: relationClick: function(d, self) { I expected you to change this "d" argument to "relation" like your other nice changes. Would be nice. :-)
https://codereview.appspot.com/7206047/diff/1/app/views/utils.js File app/views/utils.js (right):
https://codereview.appspot.com/7206047/diff/1/app/views/utils.js#newcode827 app/views/utils.js:827: * Decorate a relation with some related/derrived data. typo: derived
https://codereview.appspot.com/7206047/
« Back to merge proposal
Land with changes.
Extremely nice branch, Benji. Thank you.
Gary
https:/ /codereview. appspot. com/7206047/ diff/1/ app/views/ topology/ relation. js topology/ relation. js (right):
File app/views/
https:/ /codereview. appspot. com/7206047/ diff/1/ app/views/ topology/ relation. js#newcode834 topology/ relation. js:834: relationClick: function(d, self) {
app/views/
I expected you to change this "d" argument to "relation" like your other
nice changes. Would be nice. :-)
https:/ /codereview. appspot. com/7206047/ diff/1/ app/views/ utils.js
File app/views/utils.js (right):
https:/ /codereview. appspot. com/7206047/ diff/1/ app/views/ utils.js# newcode827 utils.js: 827: * Decorate a relation with some related/derrived
app/views/
data.
typo: derived
https:/ /codereview. appspot. com/7206047/