charmworld

Code review comment for lp:~benji/charmworld/expose-bundle-changes

  1. expose-bundle-changes
  2. Merge into trunk
Revision history for this message
Brad Crittenden (bac) wrote :

LGTM

https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py
File charmworld/jobs/ingest.py (right):

https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py#newcode424
charmworld/jobs/ingest.py:424: if revision.timestamp < since:
So since cannot be None?

https://codereview.appspot.com/15100046/diff/1/charmworld/jobs/ingest.py#newcode424
charmworld/jobs/ingest.py:424: if revision.timestamp < since:
So we're sure since can never be None?

https://codereview.appspot.com/15100046/

« Back to merge proposal