Code review comment for lp:~benji/charms/precise/juju-gui/fix-cache-headers

Revision history for this message
Benji York (benji) wrote :

> It's nice to have this logic abstracted in its own method.
> However, while this is correct for test_api_agent, test_cache_headers
> and test_branch_source, for test_staging we need to replace
> 'juju-api-agent' with 'juju-api-improv' in the list of services:

Good catch. I guess this is one reason I like to remove repetition like
this, it can trick you by not really being repetitious. :)

I've tweaked the juju_deploy method to fix this problem.

Thanks for the review.

« Back to merge proposal