Juju Charms Collection
buildbot-master package

Code review comment for lp:~benji/charms/oneiric/buildbot-master/more-tests

  1. Oneiric (11.10)
  2. more-tests
  3. Merge into trunk
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Benji,

Some of this code already landed in my branch. Hope that doesn't complicate things.

Also, the branch I landed for gmb and frankban made changes to unit_info. You may want to look at what is in trunk before attempting the merge.

As we discussed this morning there is a move afoot to follow more of PEP-8 than LP coding style so perhaps you could update the tests to getRidOfCamelCase in_favor_of_underscores?

typo: occurs not ocurrs

redundant not redunant

There is now an 'encode_file' helper if you want to use it.

review: Approve (code)

« Back to merge proposal