Code review comment for lp:~benji/charm-tools/prooflib
Revision history for this message
| Benji York (benji) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Here are my responses to the most recent round of review notes.
https:/
File Makefile (right):
https:/
Makefile:42: bzr checkout lp:~juju-jitsu/charm-tools/dependencies
On 2013/12/05 16:30:50, Marco Ceppi wrote:
> Can we not have it owned by ~juju-jitsu and instead place it under
~charmers?
Sure. Is lp:~charmers/charm-tools/dependencies an acceptable/valid
location?
https:/
Makefile:47: $(PYTHON_
dependencies
On 2013/12/05 16:30:50, Marco Ceppi wrote:
> Why wouldn't we keep requirements.txt for deps? Decoupling them means
they could
> change between versions of charm-tools and the dependencies branch.
Having the
> requirements.txt be the source for deps makes more sense to me. Unless
I'm
> missing the point of this line.
The requirements.txt file specifies the dependencies. The dependencies
directory exists so all the dependencies are conveniently available in
one place and to make sure the dependencies are available (people have a
bad habit of removing "old" distributions from the web) wile also
removing the need for web access to build the software (building on a
plane or behind an egress-filtering firewall are important use cases).
https:/